[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked 2 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in taskfilterproxymodel.cpp:34
> Not that it will make a real difference, but shouldn't this technically default to 0?
> 
> virtual desktops start at 1 with 0 being invalid.

Makes sense -- I've changed the type to uint, the default to 0 and expanded the API docs a bit.

> davidedmundson wrote in taskfilterproxymodel.cpp:298
> There was a bug that Kai found recently where some other bit of code randomly set the virtual desktop to 0 if you only had 1 virtual desktop.
> 
> (I don't know if that was in a bit of code we've replaced or not).

I've dropped the 0 check.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160601/67baeb1c/attachment.html>