Review Request 128314: Fix for bug 364530

[Chinmoy Ranjan Pradhan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128314/
-----------------------------------------------------------

(Updated July 31, 2016, 3:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 364530
    https://bugs.kde.org/show_bug.cgi?id=364530


Repository: kio


Description
-------

The function KFileItem::targetUrl() expands "desktop:/" to "/home/$USER/Desktop/" and doesn't add scheme "file" to the url. Due to this a schemeless url is passed to KRun causing KRun to show an error message despite the fact that the file exist.

The proposed patch will cause targetUrl() to check the url for a scheme and add "file" scheme if there exist no scheme.


Diffs
-----

  src/core/kfileitem.cpp b5ed5fd 

Diff: https://git.reviewboard.kde.org/r/128314/diff/


Testing
-------


File Attachments
----------------

kio_desktop.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/33d2380d-586f-4085-89d5-62fb794b8f4c__kio_desktop.patch


Thanks,

Chinmoy Ranjan Pradhan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160731/8442d729/attachment.html>