Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualActions menu

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128562/#review97944
-----------------------------------------------------------


Fix it, then Ship it!





src/scriptengines/qml/plasmoid/appletinterface.cpp (line 761)
<https://git.reviewboard.kde.org/r/128562/#comment65983>

    Should be:
    appet()->contextualActionsAboutToShow()
    
    this way if you connected to Applet::contextualActionsAboutToShow in C it'll still work.
    
    (this signal on this class will still also be emitted, there's a connect at the top)


Slightly OT but I'm sure there's some code duplication here, as ContainmentInterface is *also* trying to handle the right clicks for applets within that containment. It does the appletAt() and then loads the applets menu.
Something here that makes absolutely no sense.

- David Edmundson


On July 31, 2016, 9:26 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128562/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 9:26 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 366294
>     http://bugs.kde.org/show_bug.cgi?id=366294
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is done by ContainmentInterface::mousePressEvent, but not in this code path, which is hit for applet panel popups.
>     
> Folder View relies on this to update actions ahead of the menu being opened.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp e122db1 
> 
> Diff: https://git.reviewboard.kde.org/r/128562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160731/f00aa677/attachment.html>