Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128551/#review97907
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On July 29, 2016, 12:21 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128551/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 12:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is probably a copy-paste error as the close button's height is "parent.height * 0.8" and in a style you usually prepend "control." to everything but basing the padding on the TextField's *parent* makes no sense. While at it, fixed coding style.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d5 
> 
> Diff: https://git.reviewboard.kde.org/r/128551/diff/
> 
> 
> Testing
> -------
> 
> Fixes the filter box in eg. KTP quick chat applet having an insanely huge right padding
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160729/3653f411/attachment.html>