Review Request 128549: [TextField] Hide clear button properly

Marco Martin notmart at gmail.com
Fri Jul 29 13:57:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128549/#review97906
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On July 29, 2016, 12:15 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128549/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 12:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Opacity does not affect input handling (it did in QtQuick 1 which is probably where this comes from) so clicking the rightmost region of any TextField would unexpectedly clear it.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 
> 
> Diff: https://git.reviewboard.kde.org/r/128549/diff/
> 
> 
> Testing
> -------
> 
> Button still shows properly but clicking there when it doesn't show doesn't do anything as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160729/77f51541/attachment-0001.html>


More information about the Plasma-devel mailing list