[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2306#43005, @apol wrote:
  
  > In https://phabricator.kde.org/D2306#42989, @mart wrote:
  >
  > > seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange
  >
  >
  > What is that you don't like exactly? I can look into it if you tell me.
  
  
  it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header, not pageHeader
  
  ie it has to be as much identical as possible to 
  http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html
  
  because Page is going to inherit from that one in the future

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2306

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160729/186d9798/attachment.html>