Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Painless Roaster]

> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote:
> > It seems to work fairly well, but the editor margins are not symmetric on the left and right with respect to the item delegate frame:
> > 
> > ![Screenshot](http://i.imgur.com/2JhUtp4.png)
> 
> Painless Roaster wrote:
>     It is OK. The vertical scroller is dynamically added if need. His addition preserves text position and text wrapping. Therefore scroller is slightly to the right.
>     Try edit short text and add next characters until show scroller. You will see that this is good.
> 
> Eike Hein wrote:
>     It would be nicer if the overall editor would resize once the scrollbar appears so the margins are still symmetric, avoiding the broken appearance in the screenshot.
> 
> Painless Roaster wrote:
>     Thank you for your review. But horizontal center of editbox with scroller is not good idea. My main idea is 'the same text position and wrap in label and edit box'. If edit box show/hide vertical scroller, position of text must remain in place. Movement with editbox is disturbing for user (if user inserted char for show scroller or remove char for hide scroller).

Any news about use this patch to master branche?


- Painless


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97371
-----------------------------------------------------------


On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
> 
> (Updated Čec. 13, 2016, 1:13 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
>  - enable multiline edit
>  - fix size and position
>  - fix escape from edit if user pressed Esc
>  - fix suppress open file (or folder) if user clicked in editbox
>  - fix size and position in popup mode
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Painless Roaster
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160727/af35be7f/attachment.html>