Review Request 128493: [Button Styles] Horizontally center in icon-only mode

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/
-----------------------------------------------------------

(Updated July 26, 2016, 2:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 16f825706887ef77751ebf38cf177ce01f786bd7 by Kai Uwe Broulik to branch master.


Bugs: 365947
    http://bugs.kde.org/show_bug.cgi?id=365947


Repository: plasma-framework


Description
-------

QtQuick.Layouts by default left aligns content and because the Layout is anchors.fill'd the icon would show off-center in a button when no text has been set. This fixes this.


Diffs
-----

  src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml 1562590 

Diff: https://git.reviewboard.kde.org/r/128493/diff/


Testing
-------

* Close button icon in present window is no longer misaligned
* Close button icon in notification is no longer misaligned
* Button icons in panel controller (German locale where text is so long it hides the labels) are no longer misaligned
* Panel controller more menu buttons are fine (both the ones with and without label)
* Ran tests/components/button.qml all looked fine


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160726/68674a2b/attachment.html>