[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

[abondrov (Andrey Bondrov)]

abondrov added a comment.


  > I have no idea whatsoever, i'm just reporting a patch that the distro maintainer says it's working, but I don't know why. putting it there to discuss and trying to understand
  
  It's working because with this patch Plasma doesn't try to delete the activity it's working with.
  
  This way Plasma crashes (note that it tries to create containment for the activity destroyed with cont->destroy() earlier; also note that only panel containment tries to be created):
  -----not patched -----
  !!! checkActivities (status) 2 
  !!! checkActivities (id) "90960718-8ab6-460d-920d-3074a925c813" 
  !!! checkActivities (destroyed activity): "c51bdf4c-5df8-4b04-9cf8-88a446ad2445" 
  !!! load (containments are NOT empty, m_shell) "org.kde.plasma.desktop" 
  !!! load (containmentType == panel) 
  !!! createContainmentForActivity (activity) "c51bdf4c-5df8-4b04-9cf8-88a446ad2445" 
  !!! createContainmentForActivity (screenNum) 0
  -----not patched -----
  
  And this way it works (note that both panel and desktop try to be created):
  
  - patched -----
  
  !!! load (containments are NOT empty, m_shell) "org.kde.plasma.desktop" 
  !!! load (containmentType == panel) 
  !!! load (containmentType == desktop) 
  !!! createContainmentForActivity (activity) "94bbf033-08f1-49ca-8f58-d1963a7d6415" 
  !!! createContainmentForActivity (screenNum) 0
  
  - patched -----
  
  Maybe there's a better way to fix the crash. I hope you can reproduce it (it happens on first login, when there are no user configs yet). But for me (downstream distro) it's still better then nothing for now.

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160725/8fdc4c2b/attachment.html>