Review Request 128429: Fix strings in tooltips

Sun Jul 24 19:42:51 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128429/#review97805
-----------------------------------------------------------

When assembling tooltips with +=, every xi18nc call will return strings with "<html>...</html>", so the final tooltip will not be exactly normal rich text markup. But Qt's rich text engine is forgiving of that, so practically shouldn't be a problem.

To have clean rich text markup, one would have to conditionally produce paragraphs as KLocalizedString (with kxi18nc), store them in a list or something, and at the end based on the number of pieces create a meta-string of the type kxi18nc("@info:tooltip", "%1%2%3..."), add all the pieces with multiple .subs(), and call .toString().

processui/ProcessModel.cpp (line 1573)
<https://git.reviewboard.kde.org/r/128429/#comment65914>

    Missing closing tags.

- Chusslove Illich

On Јул 18, 2016, 7:38 по п., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128429/
> -----------------------------------------------------------
> 
> (Updated Јул 18, 2016, 7:38 по п.)
> 
> 
> Review request for Plasma, Albert Astals Cid, Chusslove Illich, and John Tapsell.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> Changed the strings to use proper kuit markup.
> 
> 
> Diffs
> -----
> 
>   processui/ProcessModel.cpp c55cea6 
> 
> Diff: https://git.reviewboard.kde.org/r/128429/diff/
> 
> 
> Testing
> -------
> 
> Viewed all the tooltips.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160724/7c003174/attachment.html>