[Differential] [Accepted] D2270: Try to be more clever about what sink to use for volume control

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> device.cpp:68
> +        return IdleState;
> +    case 2:  // PA_X_SUSPENDED
> +        return SuspendedState;

Use the values from pa_sink_state ?

> device.h:128
>      quint32 m_activePortIndex = -1;
> +    State m_state;
>  };

it's worth initialising this to Unknown.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  preferred-devices (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2270

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, ochurlaud, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160724/0c9f110c/attachment-0001.html>