[Differential] [Accepted] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog
davidedmundson (David Edmundson)
noreply at phabricator.kde.org
Fri Jul 22 14:49:32 UTC 2016
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> shutdown.cpp:187
> + }
> + QProcess *p = new QProcess(this);
> + p->setProgram(QStringLiteral(LOGOUT_GREETER_BIN));
leaks (sort of).
multiple logouts and cancels will result in lots of QProcess objects building up.
add a deleteLater in the finished slot
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
ksmserver-logout-greeter-use-process
REVISION DETAIL
https://phabricator.kde.org/D2257
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160722/95adc390/attachment.html>
More information about the Plasma-devel
mailing list