Review Request 128301: [Containment] Treat HiddenStatus as low status

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128301/
-----------------------------------------------------------

(Updated July 22, 2016, 8:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit d91127ca5866802fc3e1b5181805e2ffa4f86ae4 by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

The containment's status is the max of all applets.

Unfortunately, HiddenStatus, while semantically lower, has the highest value so as soon as there's a hidden applet (eg. pager with just one virtual desktop), the panel will always auto-hide even when popups are open as its status will be HiddenStatus.


Diffs
-----

  src/plasma/private/containment_p.cpp a72bb56 

Diff: https://git.reviewboard.kde.org/r/128301/diff/


Testing
-------

Not Bug 364847 but noticed it because of that.

Doesn't work with system tray but that's because it has its own popup and thus Plasma doesn't know that it's accepting input. I couldn't figure out how to make it work, though. I tried Plasmoid.status in the container and then a property about when the dialog is open but it just wouldn't work :(


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160722/bf707b5b/attachment.html>