Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

[Martin Tobias Holmedahl Sandsmark]

> On July 21, 2016, 5:44 a.m., Martin Gräßlin wrote:
> > How would one test this?
> 
> Martin Gräßlin wrote:
>     I mean manual testing. If I pull in the patch, what do I need to do in ksysguard to actually see it in action?

make a new tab. open the sensor browser, and look under ACPI/{Cooling Device,Thermal Zone}, they should now have more descriptive names than just "0" or "1".

if you pull some of them out you should also have more descriptive names under the graph, instead of e. g. «-1 boolean of 1 boolean».


> On July 21, 2016, 5:44 a.m., Martin Gräßlin wrote:
> > ksysguardd/Linux/acpi.h, line 45
> > <https://git.reviewboard.kde.org/r/128491/diff/2/?file=472109#file472109line45>
> >
> >     I don't see printFanState in the new code any more. Is it removed?

it should still be used by the legacy fan stuff. But I don't think I uploaded the latest patch.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128491/#review97686
-----------------------------------------------------------


On July 21, 2016, 1:13 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128491/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 1:13 a.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> Also fix the fact that cooling devices have a percentage of activity, they're not boolean on or off.
> 
> I'll reverse the tabs->spaces later, if needed.
> 
> 
> Diffs
> -----
> 
>   ksysguardd/Linux/acpi.h e50b281 
>   ksysguardd/Linux/acpi.c acf54e1 
> 
> Diff: https://git.reviewboard.kde.org/r/128491/diff/
> 
> 
> Testing
> -------
> 
> It works very well.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/44486fe2/attachment-0001.html>