[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> ivan wrote in splashapp.cpp:155
> Ok, to KWindowSystem then. It could be a method with inner cached static result so that the consecutive calls to it do not need to perform any string comparisons.
> 
> This is not really a nice thing to have in all the places copy-pasted.
> 
> Maybe a enum-returning thing such as { Unknown = 0, X11 = 1, Wayland = 2, ForExtensibility = 255 }

yes that's on my todo list since last Akademy... - in pretty much exactly the way you just outlined here.

> ivan wrote in splashwindow.cpp:151
> We had a systemd-like startkde replacement in Plasma Active called StartActive, and sebas recently told me that it was agreed it should be revived (no idea ho was in that meeting :) ). And... it is revived.
> 
> And it shares the code with ksplashqml - the splash is integrated.

well tricky then. I need to get to the kwayland integration done in KSplashApp. I need a way to get to that. And if it's not using KSplashApp that needs to be done somewhere else. If you have ideas how to solve this problem, please tell.

I don't know how start active is working and how it's integrating the code, but as a session controller I would assume it's getting started before the Wayland server is started. So the whole thing becomes mood anyway.

Anyway we had so many contenders for replacing ksmserver over the last years that I'm not going to consider hypothetical problems with possible contenders. Sorry.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: ivan, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/0526d668/attachment.html>