Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

[Andrey Bondrov]

> On June 24, 2016, 2:52 p.m., Andrey Bondrov wrote:
> > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
> > 1. KF 5.23.0
> > 2. Plasma 5.6.5
> > 3. MiminizeAll applet latest snapshot from github (May 31, 2016)
> > 4. ShowDesktop applet from Plasma 5.6.5.
> > 
> > I added MinimizeAll abd ShowDesktop applets to panel and assigned different keyboard shortcuts to them. ShowDesktop works via shortcut while MinimizeAll doesn't.
> 
> Kai Uwe Broulik wrote:
>     That is because it doesn't handle Plasmoid.onActivated - this signal is emitted when the user presses the assigned global shortcut.
>     
>     > Plasmoid.onActivated: activate()
>     
>     should do the trick

Anthony, can you please add this to the code review (but first check if it works)?


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127651/#review96844
-----------------------------------------------------------


On April 28, 2016, 8:11 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127651/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 8:11 a.m.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Kügler.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt e591c81 
>   applets/minimizeall/CMakeLists.txt PRE-CREATION 
>   applets/minimizeall/Messages.sh PRE-CREATION 
>   applets/minimizeall/package/contents/config/main.xml PRE-CREATION 
>   applets/minimizeall/package/contents/ui/main.qml PRE-CREATION 
>   applets/minimizeall/package/metadata.desktop PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION 
>   applets/minimizeall/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127651/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160428_110625.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/4c89fe92/attachment-0001.html>