Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices
Martin Gräßlin
mgraesslin at kde.org
Thu Jul 21 05:44:59 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128491/#review97686
-----------------------------------------------------------
How would one test this?
ksysguardd/Linux/acpi.h (line 45)
<https://git.reviewboard.kde.org/r/128491/#comment65829>
I don't see printFanState in the new code any more. Is it removed?
- Martin Gräßlin
On July 21, 2016, 3:13 a.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128491/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 3:13 a.m.)
>
>
> Review request for Plasma and John Tapsell.
>
>
> Repository: ksysguard
>
>
> Description
> -------
>
> Also fix the fact that cooling devices have a percentage of activity, they're not boolean on or off.
>
> I'll reverse the tabs->spaces later, if needed.
>
>
> Diffs
> -----
>
> ksysguardd/Linux/acpi.h e50b281
> ksysguardd/Linux/acpi.c acf54e1
>
> Diff: https://git.reviewboard.kde.org/r/128491/diff/
>
>
> Testing
> -------
>
> It works very well.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/9e24298b/attachment.html>
More information about the Plasma-devel
mailing list