[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> graesslin wrote in kwinqml.cpp:63
> don't use qDebug, please use categorized logging.

I'd say just remove this and debug statement below, they can get noisy, because it will be triggered at every frame repaint.

> kwinqml.cpp:112-113
> +        n = new QSGSimpleTextureNode();
> +        QSGTexture *texture = window()->createTextureFromImage(m_surface->buffer()->data());
> +        n->setTexture(texture);
> +    }

You need to move this out of the if statement, otherwise only first frame will be rendered.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/c3bb22e8/attachment.html>