[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

[graesslin (Martin Gräßlin)]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwinqml.cpp:63
> +        [this] (ShellSurfaceInterface *shellSurface) {
> +            qDebug() << "Shell surface created";
> +            m_surface = shellSurface->surface();

don't use qDebug, please use categorized logging.

> kwinqml.cpp:68
> +                    qDebug() << "Damage event recieved";
> +                    update();
> +                }

ideally you don't need to repaint everything, but could just update the actual changed areas (carried in the damaged signal)

> kwinqml.cpp:106
> +{
> +    if(!m_surface) {
> +        return node;

please watch coding style

> kwinqml.cpp:112
> +        n = new QSGSimpleTextureNode();
> +        QSGTexture *texture = window()->createTextureFromImage(m_surface->buffer()->data());
> +        n->setTexture(texture);

you cannot just assume that there's a buffer attached to the surface. Please perform a nullptr check

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160720/52c20c52/attachment-0001.html>