[Differential] [Accepted] D2223: [Notifications] Only keep job finished notification in case of an error

[graesslin (Martin Gräßlin)]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.


  asking the testing question: how can we autotest this?

INLINE COMMENTS

> broulik wrote in Jobs.qml:88
> !! is the JavaScript-way of casting to a bool, error is the KIO error number.
> 
> I could do Boolean(error) or error ? true : false if you like. I do a toBool() in the notification action but I'd prefer being explicit here

ok, I wasn't aware of this language element. It looks weird (well all of JavaScript looks weird to my C++-eyes).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/7a5519f8/attachment.html>