[Differential] [Changed Subscribers] D2223: [Notifications] Only keep job finished notification in case of an error

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue Jul 19 14:34:41 UTC 2016


graesslin added inline comments.

INLINE COMMENTS

> Jobs.qml:88
>                  body: errorText || message,
> -                isPersistent: true,
> +                isPersistent: !!error, // we'll assume success to be the note-unworthy default, only be persistent in error case
>                  urgency: 0,

why !!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/1c3a323a/attachment.html>


More information about the Plasma-devel mailing list