Review Request 128485: Reposition the krunner window if the width changes

Martin Gräßlin mgraesslin at kde.org
Tue Jul 19 05:41:38 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128485/#review97585
-----------------------------------------------------------


Ship it!




Ship It!

- Martin Gräßlin


On July 19, 2016, 6:31 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128485/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 6:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is mostly useful for the first run where the first showEvent() happens whilst we have a width of 0. Leading to krunner starting in a random place sometimes.
> 
> Width changing could also theoretically happen at any other time if a different l&f had a krunner that dynamically changed size all over the place.
> 
> 
> Diffs
> -----
> 
>   krunner/view.h 7314a2132ce5a9f409d7c164bccf99bb6ea5f144 
>   krunner/view.cpp 1783a46f1596f899936cd6137f1a606bd9ea3ffb 
> 
> Diff: https://git.reviewboard.kde.org/r/128485/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/ac26643b/attachment-0001.html>


More information about the Plasma-devel mailing list