[Differential] [Changed Subscribers] D2154: kscreen kcm: block changed signal after save

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> kcm_kscreen.cpp:154
> +
> +    QTimer::singleShot(1000, this,
> +        [this] () {

I don't really like the "magic" 1000 here. It would be nicer to have a proper way to detect it. But better than before.

Please add a comment that this is a hack and how you got the 1sec.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2154

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160718/2e8a8d13/attachment.html>