Review Request 128454: Kickoff query for CJK support

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128454/#review97432
-----------------------------------------------------------



Thanks. I can't really comment on this.


runners/services/servicerunner.h (line 58)
<https://git.reviewboard.kde.org/r/128454/#comment65738>

    use QScopedPointer instead of manually memory managing this



runners/services/servicerunner.cpp (line 52)
<https://git.reviewboard.kde.org/r/128454/#comment65733>

    delete null is fine, no need to check for that



runners/services/servicerunner.cpp (line 91)
<https://git.reviewboard.kde.org/r/128454/#comment65735>

    can you use std::remove_if



runners/services/servicerunner.cpp (line 92)
<https://git.reviewboard.kde.org/r/128454/#comment65736>

    (*it) isn't particularly pretty



runners/services/servicerunner.cpp (line 110)
<https://git.reviewboard.kde.org/r/128454/#comment65737>

    Please indicate where this belongs to, ie
    
    #endif // HAVE_KJIEBA


- Kai Uwe Broulik


On Juli 15, 2016, 7:03 vorm., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128454/
> -----------------------------------------------------------
> 
> (Updated Juli 15, 2016, 7:03 vorm.)
> 
> 
> Review request for Plasma and Xuetian Weng.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Not like English, each word is seperated by a blank, for example, Hello World, but in Chinese, ????, it needs to segment Chinese words.
> 
> And Kickoff once supported querying for CJK based on Chinese words segmentation algroithm, but about last year after KF5, the feature was dropped,  so I added an OPTIONAL requirement for KJieba - libcppjieba Chinese word segmentation DBus service.
> 
> It is able to input Chinese pinyin or even the first letters to query Application shown as https://pbs.twimg.com/media/CXSKY6YVAAAvGk8.png https://pbs.twimg.com/media/CXSKY-UUoAADWEs.png
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 74e1518 
>   runners/services/CMakeLists.txt 7e33a3e 
>   runners/services/servicerunner.h 8d9ad1a 
>   runners/services/servicerunner.cpp aa9d2bd 
> 
> Diff: https://git.reviewboard.kde.org/r/128454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160715/6c20f55f/attachment-0001.html>