[Differential] [Commented On] D2173: WIP: New System Settings delegate design

[mart (Marco Martin)]

mart added a comment.


  code seems ok, seems some pixel measures here and there, that i guess are ok.
  can you add a screenshot as well?

INLINE COMMENTS

> CategorizedView.cpp:30
>      setWordWrap( true );
> +    setViewportMargins(20,0,20,0);
> +    QPalette pal(palette());

does this give problemswith different dpis? (i guess with the scaling of the painter approach that qwidget does should be fine?)

REPOSITORY
  rSYSTEMSETTINGS System Settings

REVISION DETAIL
  https://phabricator.kde.org/D2173

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160714/ba7f5d0e/attachment.html>