[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

ivan (Ivan Čukić) noreply at phabricator.kde.org
Thu Jul 14 15:34:15 UTC 2016


ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:1588
> we use this one
> 
> you've even updated the line that's using it in this very patch.

It is using activityRemoved(QString), not activityRemoved(), It would not compile otherwise after the change to Qt5 connect syntax :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2174

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, sebas, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160714/15fd5964/attachment-0001.html>


More information about the Plasma-devel mailing list