Review Request 128445: add a subsection for removable devices

Thomas Pfeiffer thomas.pfeiffer at kde.org
Thu Jul 14 12:40:29 UTC 2016



> On July 14, 2016, 12:33 p.m., Thomas Pfeiffer wrote:
> > I just realized that we should rename the sub-group to "Removable Storage" (or "Removable Storage Media" if that isn't too long) and just treat cameras as storage media (because that's basically what they act like when connected to a PC).
> > I'll add that to the other review request.
> > With that name, this change is fine.

And please rename the "Removable Devices" KCM to "Automatic Mounting", because that's all it does configure.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128445/#review97396
-----------------------------------------------------------


On July 14, 2016, 10:39 a.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128445/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 10:39 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> now we have some kcm modules which are not connected to an subgroup the following kcm modules will be added to the subgroup removable devices when the patch was submitted
> 
> hardware
> - removable devices
>   - removable devices
>   - digital camera
>   - device actions
> 
> how it will look like when I add the patch for the different kcm's
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png
> 
> this patch don't change anything it's only an preparation.
> 
> 
> Diffs
> -----
> 
>   categories/CMakeLists.txt 9bc8307 
>   categories/old/settings-removable-devices.desktop 00098ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160714/1324cf26/attachment.html>


More information about the Plasma-devel mailing list