Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Eike Hein]

> On July 14, 2016, 7:58 a.m., Eike Hein wrote:
> > It seems to work fairly well, but the editor margins are not symmetric on the left and right with respect to the item delegate frame:
> > 
> > ![Screenshot](http://i.imgur.com/2JhUtp4.png)
> 
> Painless Roaster wrote:
>     It is OK. The vertical scroller is dynamically added if need. His addition preserves text position and text wrapping. Therefore scroller is slightly to the right.
>     Try edit short text and add next characters until show scroller. You will see that this is good.

It would be nicer if the overall editor would resize once the scrollbar appears so the margins are still symmetric, avoiding the broken appearance in the screenshot.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97371
-----------------------------------------------------------


On July 13, 2016, 1:13 p.m., Painless Roaster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 1:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
>  - enable multiline edit
>  - fix size and position
>  - fix escape from edit if user pressed Esc
>  - fix suppress open file (or folder) if user clicked in editbox
>  - fix size and position in popup mode
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Painless Roaster
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160714/f55764a6/attachment.html>