Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
Eike Hein
hein at kde.org
Thu Jul 14 07:58:58 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97371
-----------------------------------------------------------
It seems to work fairly well, but the editor margins are not symmetric on the left and right with respect to the item delegate frame:
![Screenshot](http://i.imgur.com/2JhUtp4.png)
- Eike Hein
On July 13, 2016, 1:13 p.m., Painless Roaster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
>
> (Updated July 13, 2016, 1:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
> - enable multiline edit
> - fix size and position
> - fix escape from edit if user pressed Esc
> - fix suppress open file (or folder) if user clicked in editbox
> - fix size and position in popup mode
>
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/FolderView.qml ced3507
>
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Painless Roaster
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160714/92e18f1d/attachment.html>
More information about the Plasma-devel
mailing list