[Differential] [Requested Changes To] D2073: Add a KCM setting to control pulse audio module combine-sinks

[drosca (David Rosca)]

drosca requested changes to this revision.
drosca added a reviewer: drosca.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> modulemanager.cpp:33
> +    QObject(parent),
> +    m_combineSinksConfig(new GConfItem(PA_GCONF_PATH_MODULES"/combine", this))
> +{

Can this be QStringLiteral?

> modulemanager.cpp:35
> +{
> +    connect(m_combineSinksConfig, &GConfItem::subtreeChanged , this, &ModuleManager::combineSinksChanged);
> +}

remove space before comma: `&GConfItem::subtreeChanged ,`

> modulemanager.cpp:45
> +{
> +    return m_combineSinksConfig->value("enabled").toBool();
> +}

QStringLiteral

> modulemanager.h:42
> +public:
> +    ModuleManager(QObject *parent=0);
> +    ~ModuleManager();

*parent = nullptr

> modulemanager.h:50
> +
> +protected:
> +private:

remove

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2073

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160713/2a4c576e/attachment-0001.html>