Review Request 128431: Fix race condition when new applications open

[Martin Tobias Holmedahl Sandsmark]

> On July 13, 2016, 10:44 a.m., Aleix Pol Gonzalez wrote:
> > Would it be possible to have a test there? It will be easier to review for us.

what would the test test?

nothing should call updateOrAddProcess(), ideally I'd just make it private, but I'm not sure how stable the libksysguard API is supposed to be.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128431/#review97342
-----------------------------------------------------------


On July 12, 2016, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128431/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 9:22 p.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Bugs: 261255
>     https://bugs.kde.org/show_bug.cgi?id=261255
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> When opening and closing an application quickly it sometimes got "stuck" in ksysguard because it was added by ProcessModel while Processes::processesUpdated() was running, so Processes never processed it.
> 
> 
> Diffs
> -----
> 
>   processui/ProcessModel.cpp c55cea6 
> 
> Diff: https://git.reviewboard.kde.org/r/128431/diff/
> 
> 
> Testing
> -------
> 
> It doesn't happen anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160713/900f6b87/attachment.html>