[Differential] [Accepted] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

[sebas (Sebastian Kügler)]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> slidingpopups.cpp:200
>          animating = true;
> -    } else if (mDisappearingWindows.contains(w) && w->isDeleted()) {
> +    } else if (mDisappearingWindows.contains(w)/* && w->isDeleted()*/) {
>          appearing = false;

clean up, or is this useful to keep around as a comment?

REPOSITORY
  rKWIN KWin

BRANCH
  sliding-popups-window-shown-hidden

REVISION DETAIL
  https://phabricator.kde.org/D2085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, kwin, hardening, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160712/74e54743/attachment.html>