Review Request 128372: date and time kcm remove current location time zone

Andreas Kainz kainz.a at gmail.com
Tue Jul 12 13:47:20 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128372/
-----------------------------------------------------------

(Updated Juli 12, 2016, 1:47 nachm.)


Review request for Plasma.


Changes
-------

or even better: I will merge the two tabs into one (tab's are not "allowed" according our hig's in kcm's) will upload an mockup.


Repository: plasma-desktop


Description
-------

in the kcm date and time -> timezone tab you have a description what you select in the list and than what was selected now. when you start the kcm, than you see the selected item so you know what it is now and can say. the setting is wrong I'd like to change, but when you want to change it, you don't need to know what it is now cause it is wrong otherwise you wouldn't change it and in any other kcm you don't get the information what was selected before you change it.


Diffs
-----

  kcms/dateandtime/dateandtime.ui 1a2a308 

Diff: https://git.reviewboard.kde.org/r/128372/diff/


Testing
-------


File Attachments (updated)
----------------

layout now
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/52c342cc-469e-452f-a2e4-b38d11bb23aa__dateandtime.png
0001-Fix-build.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/12/fec555a9-c206-48f3-a57d-46bbc578f4c1__0001-Fix-build.patch
merge tabs
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/12/64ee6745-27bf-4528-bb44-36b0130be9ff__dateAndTime.png


Thanks,

Andreas Kainz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160712/b9e95bc5/attachment.html>


More information about the Plasma-devel mailing list