Review Request 128400: Configuration option for System Tray's icon size

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97305
-----------------------------------------------------------


Fix it, then Ship it!





applets/systemtray/package/contents/ui/main.qml (line 35)
<https://git.reviewboard.kde.org/r/128400/#comment65695>

    since iconSizeFromTheme() is used in only one place, maybe the function can just be declared inline under the MouseArea instead of having a dedicated file?


- Marco Martin


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Configuration option for system tray's icon sizes in order to be handled by look & feel themes/packages.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160712/19a6d5b4/attachment.html>