[Differential] [Request, 35 lines] D2135: [platforms/drm] Properly handle case that mapping the blank buffer fails

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Mon Jul 11 09:30:13 UTC 2016


graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  If it's not possible to create a buffer to blank the output, KWin won't
  be able to render to the output. In that case the output should not be
  added to the list of outputs.
  
  To support this DrmOutput::blank and DrmOutput::init return bool to
  indicate whether they succeeded. DrmBackend handles this situation and
  doesn't add the output to the list of outputs if init failed.
  
  If after init there are no outputs KWin is in a state where it won't
  be functional. Thus the platform emits the initFailed signal to
  terminate.
  
  BUG: 365242
  FIXED-IN: 5.7.1

TEST PLAN
  No hardware to reproduce the condition

REPOSITORY
  rKWIN KWin

BRANCH
  drm-failed-blank-5.7

REVISION DETAIL
  https://phabricator.kde.org/D2135

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160711/05dc24fe/attachment.html>


More information about the Plasma-devel mailing list