Review Request 128409: IconItem: Use better approach to disable animation when going from invisible to visible

[David Rosca]

> On July 11, 2016, 7:52 a.m., Anthony Fieroni wrote:
> > If only remove clearing, animation still present?

There is no change in behavior. It still disables the animation when going from invisible to visible, it just fixes the bug with empty icon.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128409/#review97281
-----------------------------------------------------------


On July 9, 2016, 3:28 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128409/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 3:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Clearing the pixmap is actually wrong, because in some cases the IconItem::updatePolish() is not called when changing visibility.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h e73829b 
>   src/declarativeimports/core/iconitem.cpp 4f41b3b 
> 
> Diff: https://git.reviewboard.kde.org/r/128409/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass.
> 
> The bug (no icon rendered) can be sometimes experienced in task manager volume controls and systray popup pin button. This patch fixes it.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160711/8dfaf752/attachment.html>