Review Request 128408: IconItemTest: Set plasma theme to default rather than skipping tests if not default

David Edmundson david at davidedmundson.co.uk
Sun Jul 10 21:31:14 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128408/#review97273
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On July 9, 2016, 9:45 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128408/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 9:45 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Default plasma theme is installed with plasma-framework, so there shouldn't be reason to skip tests.
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.h e2e05c0 
>   autotests/iconitemtest.cpp e6bbc66 
> 
> Diff: https://git.reviewboard.kde.org/r/128408/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160710/2850c10f/attachment.html>


More information about the Plasma-devel mailing list