Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote:
> > Visual aspects should stay under the theme's control. Therefore, from the usability perspective, there should be no user option, instead the look & feel theme should be able to control the icon size.

I don't think that currently the theme controls it. It scales to follow the panel's size up to a certain size which is hardcoded: units.iconSizes.medium

Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a design decision or just a random pickup? :\

What I'm proposing here is let the user choose instead of having an arbitrary maximum size hardcoded. :\


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
-----------------------------------------------------------


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I didn't like the recent changes in systray icon size related to bug #364431, so I created this patch in order to make the systray's icon size user configurable
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160708/a9f59bac/attachment.html>