Review Request 128400: Configuration option for System Tray's icon size

[John Salatas]

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other applet which has this and applets in the panel usually follow the panel size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
>     Thanks for your feedback! 
>     
>     I updated the diff and I believe I have addressed all of the issues you pointed.
>     
>     I also added the usability group. 
>     
>     IMHO I don't think having this option is bad as I guess that the "correct" icon size is depended to the monitor so maybe it is better to be controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
>     well, depending from the monitor means it should depend from the monitor dpi, rather than the user (and yes, medium size was definitely too big, but i don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
>     iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
>     yes they are
> 
> John Salatas wrote:
>     My "problem" that medium size seems to be too large for me and according to the bug #364431 this doesn't seem to be the case for all users. So I though that it would be better if the size was controled by the user :\
>     
>     FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 resolution and the medium size icons seems too large in both of them :\
> 
> Kai Uwe Broulik wrote:
>     It can be controlled, by changing the panel size. If the size changed between Plasma 5.6 and 5.7 that's a bug. If it was large before already then this is expected and as it should be.

Indeed, there was a change from 5.6 to 5.7 (it was large before). 

In any case, can't we just consider what I'm proposing here (the ability to change the icon size in the systray) as a new feature? :)


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
-----------------------------------------------------------


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I didn't like the recent changes in systray icon size related to bug #364431, so I created this patch in order to make the systray's icon size user configurable
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160708/d2ab40f2/attachment.html>