Review Request 128400: Configuration option for System Tray's icon size

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
-----------------------------------------------------------



Thanks for your patch!

However, I don't think there should be such an option. There's no other applet which has this and applets in the panel usually follow the panel size indefinitely. Perhaps add the "usability" group to have them decide.

Also, I don't think this single option deserves a separage page, it would fit just fine at the top of the "General" page imho.


applets/systemtray/package/contents/ui/ConfigIcons.qml (lines 2 - 3)
<https://git.reviewboard.kde.org/r/128400/#comment65639>

    This is not you



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 31)
<https://git.reviewboard.kde.org/r/128400/#comment65640>

    Whitespace.
    
    You have lots of whitespace errors all over the place.



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 38)
<https://git.reviewboard.kde.org/r/128400/#comment65641>

    Isn't a Slider a better control for this? See FolderView icon size setting.



applets/systemtray/package/contents/ui/ConfigIcons.qml (line 67)
<https://git.reviewboard.kde.org/r/128400/#comment65642>

    Use onActivated instead which is only emitted when the user himself explicitly changes the index, ie.
    onActivated: cfg_iconSize = model[index].name
    
    ("index" is the parameter of the signal, currentIndex isn't updated at the time this signal is fired unfortunately)



applets/systemtray/package/contents/ui/main.qml (line 44)
<https://git.reviewboard.kde.org/r/128400/#comment65643>

    You could just do units.iconSizes[plasmoid.configuration.iconSize]



applets/systemtray/package/contents/ui/main.qml 
<https://git.reviewboard.kde.org/r/128400/#comment65644>

    Unrelated change


- Kai Uwe Broulik


On Juli 8, 2016, 4:29 vorm., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> -----------------------------------------------------------
> 
> (Updated Juli 8, 2016, 4:29 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I didn't like the recent changes in systray icon size related to bug #364431, so I created this patch in order to make the systray's icon size user configurable
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160708/7e442afa/attachment.html>