Review Request 128362: Add unclutter/cascade window actions

Kai Uwe Broulik kde at privat.broulik.de
Mon Jul 4 18:30:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128362/#review97087
-----------------------------------------------------------



Makes sense to put it there.


src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp (line 157)
<https://git.reviewboard.kde.org/r/128362/#comment65581>

    This looks like it leaks.
    
    QDBusConnection::sessionBus().asyncCall(QDBusMessage::createMethodCall(...));


- Kai Uwe Broulik


On Juli 4, 2016, 6:21 nachm., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128362/
> -----------------------------------------------------------
> 
> (Updated Juli 4, 2016, 6:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is the remaining useful code from the Tasks engine, which is now scheduled for removal. It will be used by the Window List plasmoid.
> 
> As discussed on IRC.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt ce0ea74 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h a9db965 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp 4850011 
> 
> Diff: https://git.reviewboard.kde.org/r/128362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160704/26ce9db9/attachment.html>


More information about the Plasma-devel mailing list