[Differential] [Commented On] D1986: WIP: Save PanelView settings in terms of grid units

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?)
  
  We /could/ but using a hybrid of two scaling systems seems like it'll get complex

INLINE COMMENTS

> mart wrote in panelview.cpp:1096
> why adding a new setter and getter that work in pixels? if something like that should be added, i wuld like just working with grid units.
> 
> perhaps having the old thickness/setThickness etc that still accept sizes in pixels for compatibility and  have new setUnitsThickness or whatever that accepts units?

I can, but that just moves the conversion into being in multiple places instead of just 1.

None of the other users of the thickness (the drag handles or working out the workspace screen area) want grid units.

> mart wrote in panelview.cpp:1098
> in the scripting the m height is binded, not the width

you're right.

  int gridUnit = QFontMetrics(QGuiApplication::font()).boundingRect(QStringLiteral("M")).height();

Will fix.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1986

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160704/6694c026/attachment.html>