Review Request 128310: standardize kcm layout for cursortheme
Andreas Kainz
kainz.a at gmail.com
Sun Jul 3 08:12:48 UTC 2016
> On Juli 2, 2016, 11:06 nachm., David Edmundson wrote:
> > Requires two tiny changes in the cpp, which I've done.
> >
> > Are you happy for me to push with the compilation fixes?
>
> Andreas Kainz wrote:
> so you already ship the request? or the change cpp file?
>
> David Edmundson wrote:
> I applied your patch, then I made it compile.
>
> Do you want me to merge it?
if possible yes, cause my system crashed so I have to redo it.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128310/#review97041
-----------------------------------------------------------
On Juli 2, 2016, 5:20 nachm., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128310/
> -----------------------------------------------------------
>
> (Updated Juli 2, 2016, 5:20 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> use the same layout for all kcm's like in plasma theme kcm.
>
>
> Diffs
> -----
>
> kcms/cursortheme/xcursor/themepage.ui 6efe60b97792cebb907159342ab66f1c9f34802a
>
> Diff: https://git.reviewboard.kde.org/r/128310/diff/
>
>
> Testing
> -------
>
> no test's done cause I don't compile anything.
>
>
> File Attachments
> ----------------
>
> final solution
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/28/36f6dc94-e43d-4742-bde0-f0681a358f63__07_MouseCursor2.png
> new
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/02/2da0a43d-949a-4b90-90c8-0609f7543747__new.png
>
>
> Thanks,
>
> Andreas Kainz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160703/b4e9770a/attachment.html>
More information about the Plasma-devel
mailing list