[Differential] [Request, 52 lines] D2059: Merge signal connections for AbstractClient in Workspace
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Fri Jul 1 14:06:06 UTC 2016
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Have one dedicated method which performs the connection for both
Client and ShellClient. This fixes the desktopPresenceChanged signal
not being passed to the effects.
Note that not all signals are merged. Most signals setup for Client
don't make sense for ShellClient as ShellClient cannot block composite
or unredirect.
TEST PLAN
Test case added for ShellClient to ensure that the signal
is correctly invoked on the ShellClient, Workspace and EffectsHandler.
REPOSITORY
rKWIN KWin
BRANCH
client-signals-workspace
REVISION DETAIL
https://phabricator.kde.org/D2059
AFFECTED FILES
autotests/integration/shell_client_test.cpp
wayland_server.cpp
workspace.cpp
workspace.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160701/04d238e4/attachment.html>
More information about the Plasma-devel
mailing list