[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

[bshah (Bhushan Shah)]

bshah requested changes to this revision.
bshah added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwinqml.cpp:73-75
> +    QProcess *kwinWayland = new QProcess(this);
> +    kwinWayland->setProcessChannelMode(QProcess::ForwardedChannels);
> +    kwinWayland->start(QStringLiteral(KWIN_INTERNAL_NAME_WAYLAND));

Somehow seems you removed code for passing socket through WAYLAND_SOCKET environment variable and passing of --xwayland argument from this code. which was in previous revisions..

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160701/6c932918/attachment.html>