Review Request 126593: [Task Manager] Add Jump List actions to grouped tasks

Heiko Tietze tietze.heiko at gmail.com
Sat Jan 30 20:24:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126593/#review91809
-----------------------------------------------------------



Hard to say if those items have to be placed at top or bottom. First impression is to have them rather at the bottom. But according the HIG "Place options that represent general options (e.g. All, None) at the beginning of the list." this patch is good.

- Heiko Tietze


On Jan. 1, 2016, 6:41 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126593/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2016, 6:41 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This just adds the jump list actions to the top of the menu as with all the other tasks.
> 
> Is it better if we place the jump list actions below the list of windows?
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/plugin/backend.cpp f83ae09 
> 
> Diff: https://git.reviewboard.kde.org/r/126593/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> Jump List Action group
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/c0479186-77e7-4d33-bb6a-49b4abaf96f1__jumplistactionongroup.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160130/bb76db06/attachment.html>


More information about the Plasma-devel mailing list