Review Request 126918: remove the legacy applets filter
David Edmundson
david at davidedmundson.co.uk
Fri Jan 29 15:00:30 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126918/#review91782
-----------------------------------------------------------
Ship it!
Ship it...but lets not do it 2 days before tagging. Wait for the next frameworks cycle.
- David Edmundson
On Jan. 28, 2016, 1:24 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126918/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 1:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this list was done because some applets broke with the new shared engine stuff.
>
> since it's many workspace releases ago, unconditionally use the single engine now.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp 48e78cd
> src/plasmaquick/private/appletquickitem_p.h 94cfada
>
> Diff: https://git.reviewboard.kde.org/r/126918/diff/
>
>
> Testing
> -------
>
> every applet in the standard distribution still works correctly (the else branch was never hit anymore)
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160129/6d00c070/attachment.html>
More information about the Plasma-devel
mailing list