Review Request 126878: [KRunner] Show single runner name

[Marco Martin]

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote:
> > * A single runner can have multiple categories in its response.
> > * I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the usability guys (and Plasma) are fine with it, ship it!
> 
> Vishesh Handa wrote:
>     *nothing wrong

it is kinda ugly i think because is really unbalanced.ùif the window was larger and the textbox taking at least half the width would probably look better (the fact that it's german, so label longer than usual also doesn't help i guess)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
-----------------------------------------------------------


On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126878/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 9:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When in single runner mode (ie. only use a specific runner rather than querying them all) show the name of the current runner.
> 
> This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should be clear that I would currently be searching through the current application's menu.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 
> 
> Diff: https://git.reviewboard.kde.org/r/126878/diff/
> 
> 
> Testing
> -------
> 
> Name properly shows, layout works both ways without the window getting wider.
> 
> I just noticed I could probably hide the category label next to the search result, too, as it's now redundant but I don't know whether a runner can still set a different value for that or if that's always just the runner name?
> 
> 
> File Attachments
> ----------------
> 
> Runner name label
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160128/defb282f/attachment.html>