Review Request 126907: [klipper] Remove "Don't ask again" on clear clipboard history

[Martin Gräßlin]

> On Jan. 27, 2016, 4:55 p.m., Thomas Pfeiffer wrote:
> > So, the situation is not that special: We ask for confirmation to err on the side of caution (which makes sense since there is no going back) but don't want to bother users with dialogs they don't care about. In fact, the situation is quite similar to removing Plasmoids.
> > 
> > Before considering any non-optimal solutions, here is what would be best from a user's perspective:
> > Do not ask for confirmation after deleting the history _but_ don't really delete it immediately. Instead, just hide it at first, and replace the empty history area with an "Undo" button. When the user adds the next entry to the list (or alternativwely after some time), actually delete the history and remove the Undo button.
> > 
> > Yes, this would certainly be more complex to implement, but it would make the dialog unnecessary while still allowing recovery in case of deletion by accident and would set a good precedent (or rather follow the precedent of Plasmoid removal).
> 
> Martin Gräßlin wrote:
>     Interesting idea. If we go for that it needs to be time based. The user might have deleted due to sensitive data being in the clipboard and does not expect that it's kept around.
>     
>     So maybe:
>      - clear current clipboard
>      - show notification
>      - after timeout clear history
> 
> Thomas Pfeiffer wrote:
>     Time-based is fine.
>     I would just still prefer putting the Undo button in Klipper itself, to keep in context. With Plasma removal, it's not possible because the Plasmoid is gone, but if we can have the undo button in context, it should be in context.

> I would just still prefer putting the Undo button in Klipper itself, to keep in context.

makes it way more complex from implementation side and doesn't work at all for "classic klipper" which closes the popup after an action is selected.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126907/#review91669
-----------------------------------------------------------


On Jan. 27, 2016, 3:13 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126907/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 3:13 p.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Bugs: 336053
>     https://bugs.kde.org/show_bug.cgi?id=336053
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the clear clipboard history action is invoked klipper shows a
> message box asking whether that's really what the user intended as
> it's a potentially dangerous action (especially on a huge clipboard).
> 
> But it also showed a "Don't ask again" checkbox which doesn't really
> make sense. When clicking "No" and the checkbox being checked it's
> becoming impossible to clear the clipboard which is probably not what
> the user intended.
> 
> This change removes the "Don't ask again" checkbox.
> 
> BUG: 336053
> 
> 
> Diffs
> -----
> 
>   klipper/klipper.cpp c80d2c7f470de2f071f59fb9629cf89a481e41c8 
> 
> Diff: https://git.reviewboard.kde.org/r/126907/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160127/2a0d677b/attachment-0001.html>