Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending
Kai Uwe Broulik
kde at privat.broulik.de
Tue Jan 26 17:44:10 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 5:44 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Jan Grulich and Lamarque Souza.
Changes
-------
Submitted with commit d8edcc6ab77836127f3cef5833bcd9e8a88a6e9f by Kai Uwe Broulik to branch master.
Repository: plasma-nm
Description
-------
It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
Diffs
-----
kded/networkmanagement.notifyrc 7ce437c
kded/notification.h 9b8b51a
kded/notification.cpp 231d69e
Diff: https://git.reviewboard.kde.org/r/126748/diff/
Testing
-------
While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after resuming.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160126/4da01944/attachment.html>
More information about the Plasma-devel
mailing list